Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-404 Add useList to parsePDR #245

Merged
merged 11 commits into from
Mar 15, 2018
Merged

CUMULUS-404 Add useList to parsePDR #245

merged 11 commits into from
Mar 15, 2018

Conversation

kkelly51
Copy link
Contributor

@kkelly51 kkelly51 commented Mar 14, 2018 •
edited
Loading

Summary: Add useList to parsePDR
(https://bugs.earthdata.nasa.gov/browse/CUMULUS-404)

Changes

  • Add useList to parsePDR

Tests:

  • Added a useList check for parse-pdr config validation in parse_pdrs_test.js
  • ftp useList tests already exists in cumulus/packages/ingest/test/ftp.js

scisco
scisco approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@scisco scisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkelly51 kkelly51 changed the title CUMULUS-404 Add useList to parsePDR [WIP] CUMULUS-404 Add useList to parsePDR Mar 14, 2018
@kkelly51 kkelly51 changed the title [WIP] CUMULUS-404 Add useList to parsePDR CUMULUS-404 Add useList to parsePDR Mar 14, 2018
laurenfrederick
laurenfrederick reviewed Mar 14, 2018
View reviewed changes
Copy link
Contributor

@laurenfrederick laurenfrederick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a CHANGELOG update before it can be merged

laurenfrederick
laurenfrederick reviewed Mar 15, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- added tools to @cumulus/integration-tests for local integration testing
- added end to end testing for discovering and parsing of PDRs
- `yarn e2e` command is available for end to end testing
- added flag `useList` to parse-pdr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under an 'Added' header in the 'Unreleased' section. Then, when we create a release, we'll add a header for that release.

@kkelly51 kkelly51 merged commit 69167ca into master Mar 15, 2018
@kkelly51 kkelly51 deleted the CUMULUS-404 branch March 15, 2018 14:28
@botanical botanical mentioned this pull request Feb 7, 2023
Merged
@botanical botanical mentioned this pull request Jun 30, 2023
Closed
@botanical botanical mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenfrederick laurenfrederick laurenfrederick left review comments

@scisco scisco scisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkelly51 @scisco @laurenfrederick